Add additional tests for maps functionality - #4
Conversation
* feat/map-sharing: pin ky@1.7.5 to fix node18 hang add tests from review Switch errors to .message not .error fix map shares test
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
It seems like there is a bug in the eventsource-client code that can mean a message can be missed before adding the async iterator. This fix uses the onMessage option to avoid missing messages.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This reverts commit 0002894.
RangerMauve
left a comment
RangerMauve
left a comment
There was a problem hiding this comment.
Minor nitpick on package.json autoformat but LGTM overall
| "src/", | ||
| "dist/" | ||
| ] | ||
| "name": "@comapeo/map-server", |
There was a problem hiding this comment.
Was converting spaces to tabs here intentional / necessary? I think it'll be reverted next time npm writes to the file.
There was a problem hiding this comment.
no idea how that happened... going to leave for now since other branches are stacked on this and I don't want to deal with resolving this for each merge - I'll fix after.
2 participants
Introduce new tests for error handling and resource management in the maps module, including scenarios for deleting and uploading maps, as well as structured error responses. Enhance error codes to improve clarity in responses.